Improve handling of mainThreadPrefix and remove redundant null check
#34746
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…method Signed-off-by: Seonghun Jeong <[email protected]>
Signed-off-by: Seonghun Jeong <[email protected]>
zzoe2346
changed the title
isCurrentThreadAllowedToHoldSingletonLock methodisCurrentThreadAllowedToHoldSingletonLock method
spring-projects-issues
added
the
status: waiting-for-triage
zzoe2346
changed the title
isCurrentThreadAllowedToHoldSingletonLock method
sbrannen
added
the
in: core
sbrannen
changed the title
mainThreadPrefix and remove redundant null check
jhoeller
added
type: task
|
Good catch! Thanks for spotting this. |
jhoeller
added a commit
that referenced
this pull request
Apr 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request refactors the
isCurrentThreadAllowedToHoldSingletonLockmethod to improve the consistency ofmainThreadPrefixvariable usage and remove a redundant null check.Changes
Consistent Variable Usage
this.mainThreadPrefixto the local variablemainThreadPrefixat the beginning of the method, the subsequentifcheck now consistently uses the local variable (if (mainThreadPrefix != null)instead of if(this.mainThreadPrefix != null)).Removed Redundant Null Check
mainThreadPrefix != nullcheck within theelse if (this.strictLocking == null)block has been removed.if (maainThreadPrefix != null)condition has already passed, guaranteeing the variable is not null at that point.I hope my PR useful :)
Thank you.